Change how JPAConfig cleans up its resources #45451
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
instead of relaying on a Destroyer. This way other components e.g. datasource should still be available.
quarkus-bot
bot
added
area/hibernate-orm
Status for workflow
|
|
🎊 PR Preview 25e8bfd has been successfully built and deployed to https://quarkus-pr-main-45451-preview.surge.sh/version/main/guides/
|
Status for workflow
|
| Status | Name | Step | Failures | Logs | Raw logs | Build scan |
|---|---|---|---|---|---|---|
| ✖ | Native Tests - Data7 | Build |
Failures | Logs | Raw logs | 🔍 |
You can consult the Develocity build scans.
Failures
⚙️ Native Tests - Data7 #
- Failing: integration-tests/hibernate-reactive-panache
📦 integration-tests/hibernate-reactive-panache
✖ Failed to execute goal io.fabric8:docker-maven-plugin:0.45.1:start (docker-start) on project quarkus-integration-test-hibernate-reactive-panache: I/O Error
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
fixes #34547
As we discussed in the linked issue, the order in which beans are destroyed is not guaranteed. With this patch, JPAConfig will observe the shutdown event and clean up the resources then.
Since persistent units are now going to be closed prior to datasource being destroyed this should allow Hibernate Search to stop things cleanly.
For the observer priority I've initially used the
ObserverMethod.DEFAULT_PRIORITYas the base value but then noticed that it uses the one from thejakarta.interceptor.Interceptor.Priorityand thought that:might be the one applicable here 😃